Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add docs prefix to img src paths in fragments #236

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix: add docs prefix to img src paths in fragments #236

merged 2 commits into from
Feb 16, 2024

Conversation

iansk
Copy link
Collaborator

@iansk iansk commented Feb 16, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 16, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 16, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@iansk
Copy link
Collaborator Author

iansk commented Feb 16, 2024

@maxakuru Can you please review my changes?

Images from fragments aren't loading. I ported over two fixes you previously made to the article block:

Issue: #193 - [Pre-prod site] Images not loading
Fixed here: PR #196

Issue: #221 - Down sampled gifs
Fixed here: PR #222

@iansk iansk requested a review from maxakuru February 16, 2024 12:28
@iansk iansk merged commit d84e600 into main Feb 16, 2024
1 of 2 checks passed
@iansk iansk deleted the iansk/fragment-imgs branch February 16, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxakuru maxakuru maxakuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images in fragments not loading
2 participants
@iansk @maxakuru